Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace & NetworkPolicy Fixes #22

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

CiraciNicolo
Copy link
Contributor

@CiraciNicolo CiraciNicolo commented Dec 5, 2024

This PR aims to fix two issues present in this helm chart:

  • Network policy indent error
  • Missing explicit namespace

The first issue is relatively straightforward to understand. Meanwhile, the rationale behind the second issue is that there are cases where it becomes quite complicated to deploy the application unless the namespace is explicitly provided — for example, when managing the application using a GitOps approach.

Signed-off-by: Nicolò Ciraci <[email protected]>
Signed-off-by: Nicolò Ciraci <[email protected]>
@lewismc
Copy link
Member

lewismc commented Dec 12, 2024

Hi @CiraciNicolo thanks for the PR!!!
All CI passes and I installed the Chart into a local K3D cluster to test.

@lewismc lewismc merged commit 10a629c into apache:main Dec 12, 2024
2 checks passed
@lewismc lewismc self-requested a review December 12, 2024 02:20
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants